fair/matrix-puppeteer-line
fair/matrix-puppeteer-line
3
0
Fork 3
Code Issues 26 Pull Requests 2 Projects Releases Wiki Activity

Doc: Python version #5

New Issue
Closed
opened 2021-05-03 00:12:00 -04:00 by lecris · 4 comments
lecris commented 2021-05-03 00:12:00 -04:00
Contributor
Copy Link

At least python 3.8 is needed for TypedDict

At least python 3.8 is needed for `TypedDict`
fair commented 2021-05-03 02:25:51 -04:00
Owner
Copy Link

Thanks for pointing this out. Type hints aren't all that critical, so I'll remove TypedDict to drop the minimum version to 3.7 (as reported by vermin).

Thanks for pointing this out. Type hints aren't all that critical, so I'll remove `TypedDict` to drop the minimum version to 3.7 (as reported by [vermin](https://github.com/netromdk/vermin)).
lecris commented 2021-05-03 02:28:06 -04:00
Author
Contributor
Copy Link

Hmm, Centos base still has 3.6 as default, and many projects are migrating to 3.8 straight, so I don't think it is necessary to remove TypedDict, just needs to be documented

I.e. if they are upgrading, they'll be upgrading straight to 3.8 anyway

Hmm, Centos base still has 3.6 as default, and many projects are migrating to 3.8 straight, so I don't think it is necessary to remove `TypedDict`, just needs to be documented I.e. if they are upgrading, they'll be upgrading straight to 3.8 anyway
fair commented 2021-05-03 02:30:31 -04:00
Owner
Copy Link

Alright, will do. Thanks!

Alright, will do. Thanks!
fair commented 2021-05-03 10:29:20 -04:00
Owner
Copy Link

d080590c54

d080590c54
fair closed this issue 2021-05-03 10:29:30 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: fair/matrix-puppeteer-line#5
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?