fair/matrix-puppeteer-line
fair/matrix-puppeteer-line
3
0
Fork 3
Code Issues 26 Pull Requests 2 Projects Releases Wiki Activity

Separate the logging #27

Open
lecris wants to merge 6 commits from lecris/matrix-puppeteer-line:logger into testing
pull from: lecris/matrix-puppeteer-line:logger
merge into: fair:testing
Conversation 1 Commits 6 Files Changed 7 +286 -267
lecris commented 2021-07-30 03:18:49 -04:00
Contributor
Copy Link

Here's an initial wip for the logger so we can mitigate the spam. Currently only wrote it for puppet.js. Had to add them all because too much spam :D. Haven't gone through all messages meticulously to figure out what type they should be, so please check them.

I've left it open so the log level can be changed at runtime, although this would only make sense if we can pipe in the log to matrix or something. At least it can be adjusted for individual users in the future.

Also maybe we can change the output so that some messages can be pipped to matrix chat

Here's an initial wip for the logger so we can mitigate the spam. ~~Currently only wrote it for `puppet.js`.~~ Had to add them all because too much spam :D. Haven't gone through all messages meticulously to figure out what type they should be, so please check them. I've left it open so the log level can be changed at runtime, although this would only make sense if we can pipe in the log to matrix or something. At least it can be adjusted for individual users in the future. Also maybe we can change the output so that some messages can be pipped to matrix chat
lecris added 1 commit 2021-07-30 03:18:50 -04:00
lecris added 1 commit 2021-07-30 03:55:02 -04:00 
Doesn't javascript support
`a?.b?.c`?
lecris added 1 commit 2021-07-30 04:02:53 -04:00
lecris added 1 commit 2021-07-30 04:39:59 -04:00
lecris added 1 commit 2021-07-30 04:45:26 -04:00
lecris added 1 commit 2021-07-30 04:47:16 -04:00
lecris changed title from Separate the logging logic to Separate the logging 2021-07-31 02:18:35 -04:00
lecris commented 2021-07-31 03:43:50 -04:00
Author
Contributor
Copy Link

I've also seen in the examples that they use chalk to color and format the log messages. Are you on board with using that?

I've also seen in the examples that they use `chalk` to color and format the log messages. Are you on board with using that?
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u logger:lecris-logger
git checkout lecris-logger
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: fair/matrix-puppeteer-line#27
No description provided.
Delete Branch "lecris/matrix-puppeteer-line:logger"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?